Enforce immutability via final and unmodifiableList.

This commit is contained in:
Holt59
2018-02-24 21:02:04 +01:00
parent 7640fa34c7
commit d00e012497
9 changed files with 504 additions and 498 deletions

View File

@@ -11,9 +11,9 @@ import java.awt.event.MouseListener;
import java.awt.geom.NoninvertibleTransformException;
import java.awt.geom.Point2D;
import java.awt.image.BufferedImage;
import java.util.ArrayList;
import java.util.IdentityHashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import javax.swing.JPanel;
@@ -238,14 +238,12 @@ public class BasicDrawing extends JPanel implements Drawing {
/**
* Draw the given arc.
*
* @param arc
* Arc to draw.
* @param palette
* Palette to use to retrieve color and width for arc, or null to use
* current settings.
* @param arc Arc to draw.
* @param palette Palette to use to retrieve color and width for arc, or null to
* use current settings.
*/
public void drawArc(Arc arc, GraphPalette palette) {
ArrayList<Point> pts = arc.getPoints();
List<Point> pts = arc.getPoints();
if (!pts.isEmpty()) {
if (palette != null) {
setColor(palette.getColorForType(arc.getInfo().getType()));

View File

@@ -1,7 +1,7 @@
package org.insa.graphics.drawing.utils;
import java.awt.Color;
import java.util.ArrayList;
import java.util.List;
import org.insa.graph.Point;
import org.mapsforge.core.graphics.Canvas;
@@ -41,7 +41,7 @@ public class PolylineAutoScaling extends Polyline {
/**
* @param points
*/
public void add(ArrayList<Point> points) {
public void add(List<Point> points) {
for (Point point: points) {
add(point);
}